-
Notifications
You must be signed in to change notification settings - Fork 345
[benchmarks] Add inference-only roofline for float8 #3167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3167
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 83ce813 with merge base 596da93 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d2a0328
to
39739d2
Compare
thoughts about putting it here instead? https://github.com/pytorch/ao/blob/main/benchmarks/float8/float8_inference_roofline.py |
whoops didnt see that one yeah I can move over |
39739d2
to
1f5d105
Compare
# kernel 1: x_bf16 -> x_nvfp4 (per-tensor scaling for inference) | ||
kernel_1_rw = BYTES_PER_EL_BF16 * numel + BYTES_PER_EL_FLOAT4 * numel | ||
# add minimal scaling overhead (per-tensor scale) | ||
kernel_1_rw += BYTES_PER_EL_FLOAT32 # single scale factor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add the blockwise scaling write here too, since we are adding it for mxfp8? just to be consistent, I don't think it will change the numbers that much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
201de29
to
e307ded
Compare
e307ded
to
83ce813
Compare
Summary