-
Notifications
You must be signed in to change notification settings - Fork 801
Move benchmarking workflow cli from testinfra to executorch #10162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 24 Unrelated FailuresAs of commit cd6b6fe with merge base cb3eba0 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
| "--models", | ||
| type=str, | ||
| required=False, | ||
| default="llama", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to branch. Users should specify what model(s) they want to benchmark with. Do not provide default seems better to me
| app_type = parser.add_mutually_exclusive_group(required=True) | ||
| app_type.add_argument( | ||
| "--android", | ||
| action="store_true", | ||
| required=False, | ||
| help="run the test on Android", | ||
| ) | ||
| app_type.add_argument( | ||
| "--ios", | ||
| action="store_true", | ||
| required=False, | ||
| help="run the test on iOS", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: to be consistent, can we rename it to "platform"?
guangy10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not forget to include the instructions to the README.md
|
@guangy10 can you remove changes requested as the PR has been updated? Thanks! |
|
There are lots of unrelated failures, so you probably want to rebase it and also fix lint before landing (I could help with that) |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Hi @Camyll! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Request from Executorch team to run android-perf or apple-perf workflows via commandline
https://github.com/pytorch/executorch/actions/workflows/android-perf.yml
https://github.com/pytorch/executorch/actions/workflows/apple-perf.yml
HOW TO:
cc @guangy10 @huydhn @kirklandsign @shoumikhin