Skip to content

Arm backend: Add TOSA support for GroupNorm #10198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Apr 15, 2025

  • Decompose groupnorm into a sequence of supported operators
  • Have some numerical issues with BI profile
  • Fix docstring in decompose_layernorm_pass
  • Add "native_group_norm.default" to CUSTOM_EDGE_OPS

Change-Id: I3f70388c12b8d9afd52876840b6c008a1b0bec4e

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Decompose groupnorm into a sequence of supported operators
- Have some numerical issues with BI profile
- Fix docstring in decompose_layernorm_pass
- Add "native_group_norm.default" to CUSTOM_EDGE_OPS

Change-Id: I3f70388c12b8d9afd52876840b6c008a1b0bec4e
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 15, 2025
Copy link

pytorch-bot bot commented Apr 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10198

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 3ef5cb2 with merge base 8e89094 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2025
@YufengShi-dudu
Copy link
Collaborator Author

Flaky behaviors on BI profile need to be investigated.
Consider to add xfails to fix it for now.

@YufengShi-dudu YufengShi-dudu requested a review from zingo April 15, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants