Implement _fft_c2r core ATen op #10208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10208
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New Failures, 1 Cancelled Job, 52 Pending, 2 Unrelated FailuresAs of commit 1a3f991 with merge base 4401fab ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73006888 |
|
This pull request was exported from Phabricator. Differential Revision: D73006888 |
pssrawat
force-pushed
the
export-D73006888
branch
from
4a6b78f to
ddfcfcd
Compare
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Apr 15, 2025
Summary: Pull Request resolved: pytorch#10208 Add ff2_c2r Differential Revision: D73006888
swolchok
requested changes
Apr 16, 2025
kernels/optimized/cpu/op_fft_c2r.cpp
Outdated
|
|
||
| namespace torch::executor::native { | ||
|
|
||
| // TODO: contents of this anonymous namespace are copy/pasted from |
There was a problem hiding this comment.
A lot of this looks copy/pasted from op_fft_r2c.cpp . Please don't do that; instead, create a header that both op_fft_r2c.cpp and this file can include.
|
This pull request was exported from Phabricator. Differential Revision: D73006888 |
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: pytorch#10208 Add ff2_c2r Differential Revision: D73006888
pssrawat
force-pushed
the
export-D73006888
branch
from
ddfcfcd to
f725f63
Compare
Summary: Pull Request resolved: pytorch#10208 Add ff2_c2r Reviewed By: swolchok Differential Revision: D73006888
|
This pull request was exported from Phabricator. Differential Revision: D73006888 |
pssrawat
force-pushed
the
export-D73006888
branch
from
f725f63 to
1a3f991
Compare
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D73006888 Pull Request resolved: pytorch#10208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add ff2_c2r
Differential Revision: D73006888