Skip to content

Use Memcpy in copy_utils #11430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jun 12, 2025
Merged

Use Memcpy in copy_utils #11430

facebook-github-bot merged 1 commit into from
Jun 12, 2025

Conversation

@ethansfng
Copy link
Contributor

@ethansfng ethansfng commented Jun 5, 2025

Summary:
standard elementwise copy in copy_utils is inefficient, use memcpy instead

Rollback Plan:

Differential Revision: D76061894

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11430

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 35bade4 with merge base d719e8e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 5, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Jun 6, 2025
@ethansfng @facebook-github-bot
Use Memcpy in copy_utils (pytorch#11430)
2d907bc 
Summary:

standard elementwise copy in copy_utils is inefficient, use memcpy instead

Rollback Plan:

Differential Revision: D76061894
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 6, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

swolchok
swolchok approved these changes Jun 10, 2025
View reviewed changes
ethansfng added a commit to ethansfng/executorch that referenced this pull request Jun 10, 2025
@ethansfng @facebook-github-bot
Use Memcpy in copy_utils (pytorch#11430)
33f6efc 
Summary:

standard elementwise copy in copy_utils is inefficient, use memcpy instead

Rollback Plan:

Differential Revision: D76061894
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 10, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

ethansfng added a commit to ethansfng/executorch that referenced this pull request Jun 10, 2025
@ethansfng @facebook-github-bot
Use Memcpy in copy_utils (pytorch#11430)
cbd6645 
Summary:

standard elementwise copy in copy_utils is inefficient, use memcpy instead

Rollback Plan:

Differential Revision: D76061894
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 10, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

ethansfng added a commit to ethansfng/executorch that referenced this pull request Jun 10, 2025
@ethansfng @facebook-github-bot
Use Memcpy in copy_utils (pytorch#11430)
5e1e415 
Summary:

standard elementwise copy in copy_utils is inefficient, use memcpy instead

Rollback Plan:

Differential Revision: D76061894
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 10, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

ethansfng added a commit to ethansfng/executorch that referenced this pull request Jun 11, 2025
@ethansfng @facebook-github-bot
Use Memcpy in copy_utils (pytorch#11430)
380bb08 
Summary:
Pull Request resolved: pytorch#11430

standard elementwise copy in copy_utils is inefficient, use memcpy instead

Reviewed By: swolchok

Differential Revision: D76061894
@ethansfng @facebook-github-bot
Use Memcpy in copy_utils (pytorch#11430)
35bade4 
Summary:
Pull Request resolved: pytorch#11430

standard elementwise copy in copy_utils is inefficient, use memcpy instead

Reviewed By: swolchok

Differential Revision: D76061894
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D76061894

@facebook-github-bot facebook-github-bot merged commit 6b4b013 into pytorch:main Jun 12, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

1 more reviewer

@swolchok swolchok swolchok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethansfng @facebook-github-bot @swolchok