Skip to content

Automatically determine presets for known platforms #11461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jun 6, 2025

Summary

For well known platforms, we should automatically infer the preset to choose if the user has not explicitly specified it. Why are am I removing this from CMakePresets.json? Just so we have a single location of mapping from platform → preset file.

If ET is used within other cmake projects, we should be able top automatically pick up the right preset!

Test plan

With this, we can finally just build with just:

$ cmake -S . -B cmake-out
$ cmake --build cmake-out -j $(sysctl -n hw.ncpu)

Presets continue to work:

$ cmake --preset ios
$ cmake --build cmake-out -j $(sysctl -n hw.ncpu)

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jun 6, 2025
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11461

Note: Links to docs will display an error until the docs builds have been completed.

❌ 37 New Failures

As of commit 1dc9fbc with merge base 2bb567f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants