Skip to content

[KleidiAI] turn on SME2 by default #13233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: gh/mcr229/45/head
Choose a base branch
from

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Aug 8, 2025

No description provided.

[ghstack-poisoned]
@mcr229
Copy link
Contributor Author

mcr229 commented Aug 8, 2025

Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13233

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit cfdebbe with merge base a84b3c9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcr229 added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: c975a52
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: b566be4
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 78fc9ba
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Aug 11, 2025
ghstack-source-id: 330a26b
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Aug 11, 2025
ghstack-source-id: 675f2ec
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Aug 11, 2025
ghstack-source-id: 32c361a
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Aug 12, 2025
ghstack-source-id: 95ac3a9
ghstack-comment-id: 3169012717
Pull Request resolved: #13233
@@ -38,6 +38,10 @@ set(XNNPACK_ENABLE_AVXVNNI
)
# Work around observed failure:
# https://github.com/pytorch/executorch/pull/10362#issuecomment-2906391232
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move around the comment?

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the test plan? Assuming Kleidi folks have tested the kernel and the XNNPACK path to the kernel is ~shared?

@mcr229
Copy link
Contributor Author

mcr229 commented Aug 12, 2025

What's the test plan? Assuming Kleidi folks have tested the kernel and the XNNPACK path to the kernel is ~shared?

cc. @mergennachin for the test plan around SME2 kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants