[ExecuTorch][WebGPU] Dynamic resize hooks for sigmoid and select_copy#20578
Open
JulianCloudNTH wants to merge 1 commit into
Open
[ExecuTorch][WebGPU] Dynamic resize hooks for sigmoid and select_copy#20578JulianCloudNTH wants to merge 1 commit into
JulianCloudNTH wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20578
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 3d8d933 with merge base 55a71e6 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 28, 2026
This PR needs a
|
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Make sigmoid and select_copy serve any live shape from one graph; fix select's last-token index under dynamic shapes.
Problem: Both ops baked their dispatch/params/output shape at
build()for the max shape.select_copywas worse: a negative index (e.g.-1for the last token) was normalized against the build-time MAX dim, so at a smaller live S it selected a stale/zero position past the live data — producing wrong (often zero) output.Solution:
sigmoid(genericadd_unary_op): a resize hook recomputesnum_elements/dispatch and sets the outputcur_dims(shape-preserving).select_copy: KEEP the raw (possibly negative) index at build; a resize hook re-resolves it against the LIVE dim, recomputes the output dims (= input minusdim), rebuilds the out/inTensorMetaUBOs and the dispatch.own_uniform_buffer.Implementation:
WebGPUTensor{dims}viafill_tensor_meta(reads only.dims).resize_*_node.Constraints: Behavior-neutral on static graphs (hooks fire only when an input's live shape differs from the max). No kernel/WGSL/numerics change.
Co-authored-with: Claude Code.
Differential Revision: D109906095