Skip to content

Deselect tflite-gated quantizer tests in internal CI#20640

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
rascani:export-D110212311
Jun 30, 2026
Merged

Deselect tflite-gated quantizer tests in internal CI#20640
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
rascani:export-D110212311

Conversation

@rascani

@rascani rascani commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary:
Internal CI flags consistently-skipping tests as broken/disabled, generating a backlog of phantom failure issues for the executorch oncall. The 56 NXP quantizer tests that require tflite always skip in fbcode since tflite isn't provisioned in that target.

Following the ARM VGF precedent (D103644035), this adds a pytest collection hook that deselects tflite-gated tests when tflite is unavailable instead of letting them skip. Deselected tests produce no signal, stopping the phantom issues. The hook is a no-op when tflite is importable, so OSS CI is unaffected.

Differential Revision: D110212311

Summary:
Internal CI flags consistently-skipping tests as broken/disabled, generating a backlog of phantom failure issues for the executorch oncall. The 56 NXP quantizer tests that require tflite always skip in fbcode since tflite isn't provisioned in that target.

Following the ARM VGF precedent (D103644035), this adds a pytest collection hook that deselects tflite-gated tests when tflite is unavailable instead of letting them skip. Deselected tests produce no  signal, stopping the phantom issues. The hook is a no-op when tflite is importable, so OSS CI is unaffected.

Differential Revision: D110212311
@rascani rascani requested a review from robert-kalmar as a code owner June 30, 2026 17:38
@pytorch-bot

pytorch-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20640

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 11 Pending

As of commit c6adce4 with merge base e095c57 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2026
@meta-codesync

meta-codesync Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110212311.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot merged commit 6f8a889 into pytorch:main Jun 30, 2026
191 of 196 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants