Skip to content

Re-land "[xplat] Update pthreadpool to google/pthreadpool github revision a56dcd7" (with patches)#20654

Open
GregoryComer wants to merge 1 commit into
pytorch:mainfrom
GregoryComer:export-D109876168
Open

Re-land "[xplat] Update pthreadpool to google/pthreadpool github revision a56dcd7" (with patches)#20654
GregoryComer wants to merge 1 commit into
pytorch:mainfrom
GregoryComer:export-D109876168

Conversation

@GregoryComer

Copy link
Copy Markdown
Member

Summary:
Attempt #2 to land the pthreadpool dependency update - D104906625 was reverted in D109744957 due to performance regressions.

I've patched back in per-thread wakeup for futex/condvar paths, as the new dispatch regresses when running with our (existing) subset of threads patch. See D107950404 for full performance testing on the new vs old stack.

Differential Revision: D109876168

…sion a56dcd7" (with patches)

Summary:
Attempt pytorch#2 to land the pthreadpool dependency update - D104906625 was reverted in D109744957 due to performance regressions.

I've patched back in per-thread wakeup for futex/condvar paths, as the new dispatch regresses when running with our (existing) subset of threads patch. See D107950404 for full performance testing on the new vs old stack.

Differential Revision: D109876168
@pytorch-bot

pytorch-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20654

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0d06e58 with merge base d54a0c0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2026
@meta-codesync

meta-codesync Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109876168.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant