Convert Args to DictConfig (#9450) #9717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9717
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e9bc206 with merge base feb3fcd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
jackzhxng
added
the
release notes: examples
jackzhxng
pushed a commit
that referenced
this pull request
Mar 28, 2025
Summary: 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Reviewed By: larryliu0820 Differential Revision: D71557301 Pulled By: jackzhxng
jackzhxng
force-pushed
the
export-D71557301
branch
from
f1f3c04 to
caf3f18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
jackzhxng
force-pushed
the
export-D71557301
branch
from
caf3f18 to
1e32696
Compare
jackzhxng
pushed a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: #9717 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Pull Request resolved: #9450 Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Reviewed By: larryliu0820 Differential Revision: D71557301 Pulled By: jackzhxng
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Summary: 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Reviewed By: larryliu0820 Differential Revision: D71557301 Pulled By: jackzhxng
facebook-github-bot
force-pushed
the
export-D71557301
branch
from
1e32696 to
d9b549f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
jackzhxng
requested review from
iseeyuan,
larryliu0820 and
swolchok
as code owners
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
2 similar comments
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
force-pushed
the
export-D71557301
branch
from
a28ddab to
a15faf6
Compare
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2025
Summary: 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Pulled By: jackzhxng jackzhxng Differential Revision: D71557301
facebook-github-bot
force-pushed
the
export-D71557301
branch
from
467568e to
cb2ba8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
facebook-github-bot
force-pushed
the
export-D71557301
branch
from
cb2ba8e to
8cb2b27
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
Summary: 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Pulled By: jackzhxng jackzhxng Differential Revision: D71557301
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
Summary: 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Pulled By: jackzhxng jackzhxng Differential Revision: D71557301
facebook-github-bot
force-pushed
the
export-D71557301
branch
from
8cb2b27 to
4054c53
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
Summary: 1. Add structure to the complicated args 2. Convert args to DictConfig, to decouple the cli args 3. Pass needed sub configs to functions (instead of args) Test Plan: ``` python3 -m examples.models.llama.export_llama -c stories110M.pt -p params.json -d fp32 -n tinyllama_xnnpack+custom_fp32_main.pte -kv -X --xnnpack-extended-ops -qmode 8da4w -G 128 --use_sdpa_with_kv_cache --output-dir tmp -E 8,64 ``` Reviewed By: larryliu0820 Pulled By: jackzhxng jackzhxng Differential Revision: D71557301
facebook-github-bot
force-pushed
the
export-D71557301
branch
from
4054c53 to
e9bc206
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71557301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Converts args to DictConfig to provide more structure and clarity
Test Plan
Existing CI