Support non-default dim orders in pybindings + aten bridge #9736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryComer
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9736
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit b2e1162 with merge base 69cc7fa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71716100 |
GregoryComer
added
release notes: misc
GregoryComer
force-pushed
the
export-D71716100
branch
from
ebd1236 to
0c91044
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71716100 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 31, 2025
) Summary: Now that we have better dim order support, we can pass inputs into models in non-default dim orders, such as channels last. This works in the runtime, but the python layer current asserts that input tensors are in default dim order. This PR relaxes this restriction to allow channels-last input tensors. Reviewed By: kimishpatel Differential Revision: D71716100
GregoryComer
force-pushed
the
export-D71716100
branch
from
0c91044 to
bed7866
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71716100 |
) Summary: Now that we have better dim order support, we can pass inputs into models in non-default dim orders, such as channels last. This works in the runtime, but the python layer current asserts that input tensors are in default dim order. This PR relaxes this restriction to allow channels-last input tensors. Reviewed By: kimishpatel Differential Revision: D71716100
GregoryComer
force-pushed
the
export-D71716100
branch
from
bed7866 to
b2e1162
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jathu
approved these changes
Mar 31, 2025
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that we have better dim order support, we can pass inputs into models in non-default dim orders, such as channels last. This works in the runtime, but the python layer current asserts that input tensors are in default dim order. This PR relaxes this restriction to allow dense input tensors with alternative dim orders.
Differential Revision: D71716100