Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart_ptr multi-turn demo #9743

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haowhsu-quic
Copy link
Collaborator

No description provided.

@haowhsu-quic haowhsu-quic requested a review from cccclai as a code owner March 28, 2025 17:49
Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9743

Note: Links to docs will display an error until the docs builds have been completed.

❌ 71 New Failures

As of commit 81abcf9 with merge base 90f0843 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@haowhsu-quic haowhsu-quic marked this pull request as draft March 28, 2025 17:49
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@billmguo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@haowhsu-quic
Copy link
Collaborator Author

Sorry I missed one thing, the CLI argument of --prompt to repro this PR is Once upon a time.

uint8_t* ptr_in = k_cache_in_prefill[i]->mutable_data<uint8_t>() - pos;
// reset decode mode pointer since it will be updated again in update_prefill_to_kv
k_cache_in_kv[i]->set_data(ptr_in);
// in order not to override existent k_cache_out
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should be existent k_cache_in.

@cccclai
Copy link
Contributor

cccclai commented Mar 30, 2025

Yeah I print the result and it looks like following

Once upon a time, there was a little girl named Lily. She loved to play with her toys and her favorite toy was a big, red ball. One day, Lily's mom asked her to help her with the laundry. Lily was happy to help and she put all the clothes in the washing machine.
After the clothes were washed, Lily's mom asked her to help her hang them up to dry. Lily grabbed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants