Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XNNPACK] Serialize weights as fp16 rather than fp32 #9753

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Mar 29, 2025

Summary

Previously we've used FP32_STATIC_WEIGHTS flag in xnnpack to coerce fp32 weights into fp16 for linear and conv. This allowed us to mimc fp16 computation because the weights would be converted and packed as fp16 at runtime. However, this means we lose the benefit of the smaller .pte file because the weights are serialized as fp32 rather than fp16. Additionally, we still have to load the weights as fp32, since they are converted at runtime. This has some poor effects on performance

Test plan

python -m unittest backends.xnnpack.test.ops.test_linear.TestLinear.test_fp16_linear
python -m unittest backends.xnnpack.test.ops.test_linear.TestLinear
python -m unittest backends.xnnpack.test.ops.test_conv2d.TestConv2d

Llama 3.2 with bf16 weights:
Before:

-rw-r--r--  1 maxren  staff  5468937344 Mar 28 17:00 llama3_2_fp16_direct_convert_runtime.pte

After:

-rw-r--r--  1 maxren  staff  2997443712 Mar 28 16:57 llama3_2_fp16_direct_convert_runtime.pte

@mcr229 mcr229 requested a review from digantdesai March 29, 2025 00:02
Copy link

pytorch-bot bot commented Mar 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9753

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cb31420 with merge base ce74f8e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2025
@mcr229 mcr229 changed the base branch from fp16 to main March 29, 2025 00:06
@mcr229 mcr229 requested a review from GregoryComer March 31, 2025 17:35
@@ -368,7 +368,7 @@ def define_tensor( # noqa: C901
constant data. If used along with convert_to_nhwc, this
swap will happen before converting to nhwc.
quant_params: Quantization meta data for this tensor, None if it is not quantized
fp32_static_weights: XNN_FLAG_FP32_STATIC_WEIGHTS for fp16 conv
force_fp32: forces tensor to be serialize as fp32, used for bias of dynamically quantized ops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fp32_static_weight/force_fp32 - seems a little too vague if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants