Skip to content

Remove pre-cxx-abi mention for libtorch builds #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 8, 2025
Merged

Remove pre-cxx-abi mention for libtorch builds #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2bbdbf2
Remove pre-cxx-abi mention
atalman Apr 8, 2025
6f2e33a
Merge branch 'site' into fix_update_quick_start
atalman Apr 8, 2025
54db730
remove from nightly
atalman Apr 8, 2025
f9b41d5
Revert "remove from nightly"
atalman Apr 8, 2025
5404187
fixes
atalman Apr 8, 2025
af73738
fix
atalman Apr 8, 2025
122ce40
fix
atalman Apr 8, 2025
0d4abbf
Merge branch 'site' into fix_update_quick_start
atalman Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions published_versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,28 +52,24 @@
"accnone": {
"note": null,
"versions": {
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cpu/libtorch-shared-with-deps-latest.zip",
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cpu/libtorch-cxx11-abi-shared-with-deps-latest.zip"
}
},
"cuda.x": {
"note": null,
"versions": {
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu118/libtorch-shared-with-deps-latest.zip",
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu118/libtorch-cxx11-abi-shared-with-deps-latest.zip"
}
},
"cuda.y": {
"note": null,
"versions": {
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu126/libtorch-shared-with-deps-latest.zip",
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu126/libtorch-cxx11-abi-shared-with-deps-latest.zip"
}
},
"cuda.z": {
"note": null,
"versions": {
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu128/libtorch-shared-with-deps-latest.zip",
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu128/libtorch-cxx11-abi-shared-with-deps-latest.zip"
}
},
Expand Down Expand Up @@ -5863,4 +5859,4 @@
}
}
}
}
}
5 changes: 3 additions & 2 deletions scripts/gen_quick_start_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,9 @@ def update_versions(versions, release_matrix, release_version):
if x["libtorch_variant"] == "shared-with-deps"
}
if instr["versions"] is not None:
for ver in [PRE_CXX11_ABI, CXX11_ABI]:
if gpu_arch_type == "rocm" and ver == PRE_CXX11_ABI:
for ver in [CXX11_ABI, PRE_CXX11_ABI]:
# temporarily apply removal of cxx11 abi only to nightly and rocm builds
if ver == PRE_CXX11_ABI and (release_version == "nightly" or gpu_arch_type == "rocm"):
continue
else:
instr["versions"][LIBTORCH_DWNL_INSTR[ver]] = (
Expand Down
Loading