Skip to content

Remove updating pre-cxx-abi mention for libtorch release builds as well #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Remove updating pre-cxx-abi mention for libtorch release builds as well #1979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/gen_quick_start_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,9 @@ def update_versions(versions, release_matrix, release_version):
}
if instr["versions"] is not None:
for ver in [CXX11_ABI, PRE_CXX11_ABI]:
# temporarily apply removal of cxx11 abi only to nightly and rocm builds
if ver == PRE_CXX11_ABI and (release_version == "nightly" or gpu_arch_type == "rocm"):
# temporarily remove setting pre-cxx11-abi. For Release 2.7 we
# should remove pre-cxx11-abi completely.
if ver == PRE_CXX11_ABI:
continue
else:
instr["versions"][LIBTORCH_DWNL_INSTR[ver]] = (
Expand Down
Loading