[Feature] Add option for auto-resetting envs in GAE #2851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when calculating the GAE, torchrl assumes that there is a valid
s_(t+1)
return from the environment. However, for auto-resetting environments, that is not true at the end of the episode, as it just jumps to the first state of the next episode. This PR adds a feature to the GAE class, allowing users to specify if it's an auto-resetting env, in which case it will use thes_t
as an approximation for bootstrapping.Motivation and Context
Without this change, we were getting much slower convergence rates during training for IsaacLab (an autoresetting env).
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!