Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use template from pull.yml for run-readme-pr.yml since pip3 not available in current environment #1489

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented Feb 6, 2025

use template from pull.yml for run-readme-pr.yml since pip3 not available in current environment

mikekgfb and others added 30 commits January 23, 2025 18:36
source test commands instead of executing them.  
(Possible fix for pytorch#1315 )
source instead of exec
somebody pushed all the model exports into exportedModels, but... we never create the directory.

we should do that also do this in the user instructions, just because storing into a directory that doesn't exist is not good :)
multimodal doc needed end of tests comment.
Need to download files before using them, lol. We expect the users to do this, but we should verbalize.  Plus, if we extract for testing, then it obviously fails.
( triggers unexpected token in macos zsh
          # metadata does not install properly on macos
          # .ci/scripts/run-docs multimodal
          # metadata does not install properly on macos
          # .ci/scripts/run-docs multimodal
          echo ".ci/scripts/run-docs native DISABLED"
          # .ci/scripts/run-docs native
          echo ".ci/scripts/run-docs native DISABLED"
          # .ci/scripts/run-docs native
switch to gs=32 quantization
(requires consolidated run-docs of pytorch#1439)
add gs=32 cuda quantization for use w/ stories15M
add gs=32 for stories15M
Comment out tests that currently fail, as per summary in PR comments
Dump location of executable to understand these errors:
https://hud.pytorch.org/pr/pytorch/torchchat/1476#36452260294

2025-01-31T00:18:57.1405698Z + pip3 install -r install/requirements.txt --extra-index-url https://download.pytorch.org/whl/nightly/cpu
2025-01-31T00:18:57.1406689Z ./install/install_requirements.sh: line 101: pip3: command not found
dump candidate locations for pip
Some of the updown commands were getting rendered. Not sure why/when that happens?
readme switched from llama3 to llama3.1, so replace llama3.1 with stories15M
remove failing gguf test
Remove failing gguf test
Can we mix `steps:` with `script: |` in git workflows?

Testing 123 testing!
remove quotes around replace as the nested quotes are not interpreted by the shall but seem to be passed to updown.py.

We don't have spaces in replace, so no need for escapes.
mikekgfb and others added 7 commits January 31, 2025 14:51
1 - Remove steps experiment.
2 - add at-get install pip3

Maybe releng needs to look at what's happening with pip?
remove quotes that mess up parameter identification.
try to install pip & pip3
debug

        which pip || true
        which pip3 || true
        which conda || true
debug info

```
        which pip || true
        which pip3 || true
        which conda || true
```
Copy link

pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1489

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 1 Unrelated Failure

As of commit 18ba560 with merge base 53a1004 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 6, 2025
@digantdesai digantdesai requested a review from Jack-Khuu February 7, 2025 18:06
@digantdesai digantdesai added enhancement New feature or request triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 7, 2025
@Jack-Khuu Jack-Khuu added the CI Infra Issues related to CI infrastructure and setup label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Infra Issues related to CI infrastructure and setup CLA Signed This label is managed by the Meta Open Source bot. enhancement New feature or request triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants