-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use template from pull.yml for run-readme-pr.yml since pip3 not available in current environment #1489
Open
mikekgfb
wants to merge
41
commits into
pytorch:main
Choose a base branch
from
mikekgfb:newtemplate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source test commands instead of executing them. (Possible fix for pytorch#1315 )
source instead of exec
somebody pushed all the model exports into exportedModels, but... we never create the directory. we should do that also do this in the user instructions, just because storing into a directory that doesn't exist is not good :)
multimodal doc needed end of tests comment.
Need to download files before using them, lol. We expect the users to do this, but we should verbalize. Plus, if we extract for testing, then it obviously fails.
( triggers unexpected token in macos zsh
# metadata does not install properly on macos # .ci/scripts/run-docs multimodal
# metadata does not install properly on macos # .ci/scripts/run-docs multimodal
install wget
echo ".ci/scripts/run-docs native DISABLED" # .ci/scripts/run-docs native
echo ".ci/scripts/run-docs native DISABLED" # .ci/scripts/run-docs native
switch to gs=32 quantization (requires consolidated run-docs of pytorch#1439)
add gs=32 cuda quantization for use w/ stories15M
add gs=32 for stories15M
Comment out tests that currently fail, as per summary in PR comments
Dump location of executable to understand these errors: https://hud.pytorch.org/pr/pytorch/torchchat/1476#36452260294 2025-01-31T00:18:57.1405698Z + pip3 install -r install/requirements.txt --extra-index-url https://download.pytorch.org/whl/nightly/cpu 2025-01-31T00:18:57.1406689Z ./install/install_requirements.sh: line 101: pip3: command not found
dump candidate locations for pip
Some of the updown commands were getting rendered. Not sure why/when that happens?
readme switched from llama3 to llama3.1, so replace llama3.1 with stories15M
remove failing gguf test
Remove failing gguf test
Can we mix `steps:` with `script: |` in git workflows? Testing 123 testing!
remove quotes around replace as the nested quotes are not interpreted by the shall but seem to be passed to updown.py. We don't have spaces in replace, so no need for escapes.
1 - Remove steps experiment. 2 - add at-get install pip3 Maybe releng needs to look at what's happening with pip?
remove quotes that mess up parameter identification.
try to install pip & pip3
debug which pip || true which pip3 || true which conda || true
debug info ``` which pip || true which pip3 || true which conda || true ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1489
Note: Links to docs will display an error until the docs builds have been completed. ❌ 17 New Failures, 1 Unrelated FailureAs of commit 18ba560 with merge base 53a1004 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
indentation fixup
Don't specify Pytorch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI Infra
Issues related to CI infrastructure and setup
CLA Signed
This label is managed by the Meta Open Source bot.
enhancement
New feature or request
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use template from pull.yml for run-readme-pr.yml since pip3 not available in current environment