Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ET Runner instructions #691

Merged
merged 4 commits into from
May 20, 2024
Merged

add ET Runner instructions #691

merged 4 commits into from
May 20, 2024

Conversation

byjlw
Copy link
Contributor

@byjlw byjlw commented May 6, 2024

Add in details on how to run the ET runner

@byjlw byjlw requested a review from kimishpatel May 6, 2024 15:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 6, 2024
@byjlw byjlw marked this pull request as ready for review May 6, 2024 15:52
@byjlw byjlw requested review from orionr and mikekgfb May 6, 2024 17:44
@mikekgfb
Copy link
Contributor

mikekgfb commented May 7, 2024

CI says these instructions don't work, on either macOS (no MPS) or x86/Linux with CUDA. (We're missing x86 no cuda, and macOS-14+MPS)

Can you please check what is broken in this version of the README

Copy link

pytorch-bot bot commented May 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/691

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 838705b with merge base a80ae4d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


Execute using the runner
```bash
cmake-out/et_run llama3.pte -z ~/.torchchat/model-cache/meta-llama/Meta-Llama-3-8B-Instruct/tokenizer.model -i "Once upon a time"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a command to get the path of the lcoal model cache for any model, got torchchat.py where

cmake-out/et_run llama3.pte -z `python3 torchchat.py where llama3`/tokenizer.model -i "Once upon a time"

Well, really I would love to type tc where llama3 :-)

@mikekgfb mikekgfb merged commit 6c39a4a into main May 20, 2024
52 checks passed
@mikekgfb mikekgfb deleted the add-ET-Runner-Instructions branch May 20, 2024 06:29
malfet pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Michael Gschwind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants