Skip to content

Add max retries to quorum to avoid live locks #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 18, 2025
Merged

Add max retries to quorum to avoid live locks #166

merged 8 commits into from
Apr 18, 2025

Conversation

msaroufim
Copy link
Member

Fixes #151

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 16, 2025
d4l3k
d4l3k approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for sending this! Code looks good though one question on checkpointing behavior

@d4l3k d4l3k merged commit 4961e56 into pytorch:main Apr 18, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add max retries to quorum to avoid live locks
3 participants
@msaroufim @d4l3k @facebook-github-bot