MonitoredQueue: fail fast when subprocess exits #99
+214
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
d4l3k/monitor_queue
branch
from
9bc6269 to
9abc936
Compare
H-Huang
approved these changes
Feb 5, 2025
| @@ -573,8 +553,8 @@ class _BabyWork(Work): | |||
| def __init__( | |||
| self, | |||
| pg: "ProcessGroupBaby", | |||
| tx: mp.Queue, | |||
| rx: mp.Queue, | |||
| tx: _MonitoredQueue, | |||
There was a problem hiding this comment.
What are tx and rx meant to represent?
There was a problem hiding this comment.
These are the raw communication channels with the subprocess, might be good to refactor these so all queue comms go through the PG
| @@ -739,7 +739,7 @@ def _worker( | |||
| try: | |||
| pg = cls._create_pg(store, rank, world_size) | |||
| except Exception as e: | |||
| logger.exception(f"got exception in worker: {e}") | |||
| print(f"got exception in worker: {e}", file=sys.stderr) | |||
There was a problem hiding this comment.
any particular reason for the logger -> print change?
There was a problem hiding this comment.
We're not initializing the logger in the subprocess so switched to stderr to make sure we actually log these
Maybe I should just instantiate a second logger as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wrapper around mp.Queue that fails fast when the subprocess exits. This means if subprocess BabyNCCL crashes we will report the error quickly rather than waiting for the timeout to elapse.
Test plan: