positional and kwargs corner case fix in for _build_args_kwargs #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68892351 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jan 31, 2025
…rch#2714) Summary: ## Context: Setting None in positional args is colliding with the kwargs in situations when kwargs contains the argument name accepted by the method. Eg : ``` def input_dist(ctx, id_feature_list): ... // If _build_args_kwargs returns: args = [None] kwargs = {'id_feature_list': KJT} input_dist(ctx, *args, **kwargs) // extends to input_dist(ctx, None, id_feature_list=KJT) ``` which results in "TypeError: got multiple values for argument 'id_feature_list'" because id_feature_list is provided both positionally (None) and via kwargs. ## Fix: Ensure _build_args_kwargs does not append None to args when an argument is already correctly assigned in kwargs. Differential Revision: D68892351
aliafzal
force-pushed
the
export-D68892351
branch
from
fa5ae8f to
ebc45fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68892351 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Feb 4, 2025
…rch#2714) Summary: ## Context: Setting None in positional args is colliding with the kwargs in situations when kwargs contains the argument name accepted by the method. Eg : ``` def input_dist(ctx, id_feature_list): ... // If _build_args_kwargs returns: args = [None] kwargs = {'id_feature_list': KJT} input_dist(ctx, *args, **kwargs) // extends to input_dist(ctx, None, id_feature_list=KJT) ``` which results in "TypeError: got multiple values for argument 'id_feature_list'" because id_feature_list is provided both positionally (None) and via kwargs. Reviewed By: sarckk Differential Revision: D68892351
aliafzal
force-pushed
the
export-D68892351
branch
from
ebc45fe to
b90ac7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68892351 |
…rch#2714) Summary: ## Context: Setting None in positional args is colliding with the kwargs in situations when kwargs contains the argument name accepted by the method. Eg : ``` def input_dist(ctx, id_feature_list): ... // If _build_args_kwargs returns: args = [None] kwargs = {'id_feature_list': KJT} input_dist(ctx, *args, **kwargs) // extends to input_dist(ctx, None, id_feature_list=KJT) ``` which results in "TypeError: got multiple values for argument 'id_feature_list'" because id_feature_list is provided both positionally (None) and via kwargs. Reviewed By: sarckk Differential Revision: D68892351
aliafzal
force-pushed
the
export-D68892351
branch
from
b90ac7e to
3e04bad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68892351 |
aliafzal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
Setting None in positional args is colliding with the kwargs in situations when kwargs contains the argument name accepted by the method.
Eg :
which results in "TypeError: got multiple values for argument 'id_feature_list'" because id_feature_list is provided both positionally (None) and via kwargs.
Differential Revision: D68892351