Skip to content

Re-land torchrec pipeline refactor (with fix) #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

che-sh
Copy link
Contributor

@che-sh che-sh commented Mar 28, 2025

Summary:
Reintroduces #2741 with fix

Note: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing

Reviewed By: sarckk

Differential Revision: D71086956

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71086956

che-sh added a commit to che-sh/torchrec that referenced this pull request Mar 28, 2025
Summary:

Reintroduces pytorch#2741 with fix

**Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing

Reviewed By: sarckk

Differential Revision: D71086956
@che-sh che-sh force-pushed the export-D71086956 branch from 7ac60df to 82201f6 Compare March 28, 2025 03:55
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71086956

@che-sh che-sh force-pushed the export-D71086956 branch from 82201f6 to a382906 Compare April 16, 2025 06:12
che-sh added a commit to che-sh/torchrec that referenced this pull request Apr 16, 2025
Summary:

Reintroduces pytorch#2741 with fix

**Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing

Reviewed By: sarckk

Differential Revision: D71086956
Summary:
Pull Request resolved: pytorch#2853

Reintroduces pytorch#2741 with fix

**Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing

Reviewed By: sarckk

Differential Revision: D71086956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71086956

@che-sh che-sh force-pushed the export-D71086956 branch from a382906 to 132b222 Compare April 16, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants