[TorchComms] integration CI tests #1927
Merged
+153
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
d4l3k
reviewed
Oct 21, 2025
| pip config --user set global.progress_bar off | ||
|
|
||
| python -m pip install --force-reinstall --pre torch torchcomms --index-url https://download.pytorch.org/whl/nightly/cu128 | ||
| ./build_ncclx.sh |
There was a problem hiding this comment.
don't need this line if we're installing nightly wheels
mori360
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
fduwjj
reviewed
Oct 21, 2025
| with: | ||
| runner: linux.g5.48xlarge.nvidia.gpu | ||
| gpu-arch-type: cuda | ||
| gpu-arch-version: "12.6" |
There was a problem hiding this comment.
when we install cuda for pytorch we use 128, shall we also use 12.8 here?
There was a problem hiding this comment.
Thanks for the comments, update to 12.8
fduwjj
reviewed
Oct 21, 2025
fduwjj
approved these changes
Oct 21, 2025
fegin
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.