Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to customize dataloader #836

Merged
merged 17 commits into from
Feb 14, 2025
Merged

Allow users to customize dataloader #836

merged 17 commits into from
Feb 14, 2025

Conversation

fegin
Copy link
Contributor

@fegin fegin commented Feb 12, 2025 •
edited
Loading

@fegin
Update
834b9ea 
[ghstack-poisoned]
This was referenced Feb 12, 2025
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 12, 2025
fegin added 2 commits February 12, 2025 00:03
@fegin
Update
1af1c1b 
[ghstack-poisoned]
@fegin
Update
c9e996d 
[ghstack-poisoned]
@fegin fegin requested review from fduwjj and tianyu-l February 12, 2025 08:25
fegin added 2 commits February 12, 2025 00:35
@fegin
Update
e9fb99f 
[ghstack-poisoned]
@fegin
Update
3898369 
[ghstack-poisoned]
fduwjj
fduwjj approved these changes Feb 12, 2025
View reviewed changes
@fegin
Update
b38cfc3 
[ghstack-poisoned]
tianyu-l
tianyu-l reviewed Feb 12, 2025
View reviewed changes
fegin added 2 commits February 13, 2025 10:21
@fegin
Update
a350c55 
[ghstack-poisoned]
@fegin
Update
cbe06ba 
[ghstack-poisoned]
tianyu-l
tianyu-l approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@tianyu-l tianyu-l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please address the comment before merging.
oh also CI is failing on memory estimation script.

fegin added 9 commits February 13, 2025 15:05
@fegin
Update
2a6460c 
[ghstack-poisoned]
@fegin
Update
2d9a237 
[ghstack-poisoned]
@fegin
Update
41ddfe7 
[ghstack-poisoned]
@fegin
Update
3d4d6c1 
[ghstack-poisoned]
@fegin
Update
864799b 
[ghstack-poisoned]
@fegin
Update
82856d0 
[ghstack-poisoned]
@fegin
Update
2649ded 
[ghstack-poisoned]
@fegin
Update
93d3eb4 
[ghstack-poisoned]
@fegin
Update
69b2e62 
[ghstack-poisoned]
@fegin fegin merged commit 69b2e62 into gh/fegin/11/base Feb 14, 2025
6 checks passed
@fegin fegin mentioned this pull request Feb 14, 2025
Merged
fegin added a commit that referenced this pull request Feb 14, 2025
@fegin
Allow users to customize dataloader (#843)
5542f56 
Land #836
@fegin fegin deleted the gh/fegin/11/head branch February 14, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@tianyu-l tianyu-l tianyu-l approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fegin @fduwjj @tianyu-l @facebook-github-bot