Add Context Parallel tutorial #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3319
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5872433 with merge base 7cb6915 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
reviewed
Apr 10, 2025
wconstab
reviewed
Apr 10, 2025
wconstab
approved these changes
Apr 11, 2025
| out = F.scaled_dot_product_attention(*qkv, is_causal=True) | ||
|
|
||
| # make a clean copy of QKV for output comparison | ||
| cp_qkv = [t.detach().clone() for t in qkv] |
There was a problem hiding this comment.
Ahh, so this is not even needed for cp just for the reference?
I wonder if it's better to delete the reference. That's more appropriate for a unit test, but for an example people usually want something that's minimal and copy able, and in this case they might be distracted by this line.
AlannaBurke
requested changes
Apr 12, 2025
fegin
approved these changes
Apr 14, 2025
fegin
suggested changes
Apr 14, 2025
|
Can you please rebase the base branch to main. |
AlannaBurke
approved these changes
Apr 15, 2025
Summary: The compiled model run takes the same input as Eager. No need to explicitly compose args as a tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch 2.7 release of
torch.distributed.tensor.experimental._attentionAPI: https://pytorch.org/docs/stable/distributed.tensor.html#torch.distributed.tensor.experimental.context_parallel
tutorial preview: https://docs-preview.pytorch.org/pytorch/tutorials/3319/prototype/context_parallel.html