Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore uv.lock #192

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

RealCLanger
Copy link
Collaborator

This file gets created on my Windows. Should be ignored for git.

@RealCLanger RealCLanger merged commit 5d8042d into pytr-org:master Feb 14, 2025
6 checks passed
@RealCLanger RealCLanger deleted the gitignore-uv-lock branch February 14, 2025 14:28
@NiklasRosenstein
Copy link
Collaborator

I was thinking about adding a PR to commit the file, actually. That would be one way to avoid running into issues like the one we had with the websocket package, there would always be a known working combination of dependencies with locked version numbers in the repository.

FWIW the websocket issue could've also been avoided by not allowing the next major version to be used as a dependency before it is tested.

@RealCLanger
Copy link
Collaborator Author

If it makes sense to add the file, rather than ignoring it, please feel free to do so. I'm not too knowledgeable in that area 😉

CoLdIcE42 pushed a commit to CoLdIcE42/pytr that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants