Handle bonds calculation in portfolio #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aleksandrzhiliaev , thanks for your contribution! Would you be able to provide an example event data for a bonds transaction? I'm also thinking if this change would be better suited in another place, or needed also in another place, because there's a few more places that use the same API and don't handle bonds special (e.g. exporting to CSV). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, just found that bonds calculation gives wrong numbers in portfolio list that also gives wrong amount of Depot sum in the end, that PR fixes netValue by assuming that we are dealing with bonds in name.