Fix dividends on knock-outs #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this makes sense overall. It would be good to have a test case with an added example event, also to have some data at hand for developers that don't have such events at hand in their own account. |
nagy
force-pushed
the
dividends-knockouts
branch
from
7ce0959 to
bcfa8aa
Compare
|
I have added a test for this. |
RealCLanger
requested changes
Jul 2, 2025
RealCLanger
reviewed
Jul 2, 2025
|
The tests seem to pass and it is a lot cleaner now. Thank you. |
|
I just submitted larger changes for parsing to the mainline. Can you merge these changes into your PR, then we can finalize this. |
On (knockout-)options, before this it would assign the ISIN of the underlying instrument instead of the ISIN of the option itself and the amount of options was also missing.
nagy
force-pushed
the
dividends-knockouts
branch
from
04ebc5f to
4fabea4
Compare
|
Done. Thank you for your work. |
Thank you, I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On (knockout-)options, before this it would assign the ISIN of the underlying instrument instead of the ISIN of the option itself and the amount of options was also missing.
If you want I can also craft a testcase for this.