-
Notifications
You must be signed in to change notification settings - Fork 80
Start deprecating automatic tle downloads #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
pre-commit.ci autofix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 90.43% 90.46% +0.02%
==========================================
Files 18 19 +1
Lines 3011 3019 +8
==========================================
+ Hits 2723 2731 +8
Misses 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnuu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of typos, otherwise LGTM
Co-authored-by: Panu Lahtinen <[email protected]>
This PR starts deprecating automatic tle fetching from celestrak.
Automatic downloads are convenient when prototyping, however there are several reasons this should not be enabled by default, among which:
Celestrak is throttled, meaning that a user can get banned (temporarily) after running automatic downloads for a while
For operational environments, where this code can be run a lot, internet connection quality (plus the throttling above) can be a concern
For consistency in automated tests, it is important to keep testing on the same data, not one automatically refreshed from the internet
Downloading TLE from the internet takes a little time, which can be avoided by having a local TLE cache.
Closes #xxxx
Tests added
Fully documented