Skip to content

Conversation

@mraspaud
Copy link
Member

This PR starts deprecating automatic tle fetching from celestrak.

Automatic downloads are convenient when prototyping, however there are several reasons this should not be enabled by default, among which:

  • Celestrak is throttled, meaning that a user can get banned (temporarily) after running automatic downloads for a while

  • For operational environments, where this code can be run a lot, internet connection quality (plus the throttling above) can be a concern

  • For consistency in automated tests, it is important to keep testing on the same data, not one automatically refreshed from the internet

  • Downloading TLE from the internet takes a little time, which can be avoided by having a local TLE cache.

  • Closes #xxxx

  • Tests added

  • Fully documented

@mraspaud mraspaud self-assigned this Oct 13, 2025
@mraspaud
Copy link
Member Author

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (b10cfeb) to head (860e0aa).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   90.43%   90.46%   +0.02%     
==========================================
  Files          18       19       +1     
  Lines        3011     3019       +8     
==========================================
+ Hits         2723     2731       +8     
  Misses        288      288              
Flag Coverage Δ
unittests 90.46% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Oct 13, 2025

Coverage Status

coverage: 90.421% (+0.02%) from 90.399%
when pulling 860e0aa on mraspaud:disable-tle-dl
into 10467c0 on pytroll:main.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos, otherwise LGTM

Co-authored-by: Panu Lahtinen <[email protected]>
@mraspaud mraspaud merged commit f1c2797 into pytroll:main Oct 15, 2025
16 checks passed
@mraspaud mraspaud deleted the disable-tle-dl branch October 15, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants