Skip to content

Conversation

@djhoese
Copy link
Member

@djhoese djhoese commented Oct 17, 2025

According to https://en.wiktionary.org/wiki/excentricity "excentricity" is the "Archaic form of eccentricity. This PR renames the properties in the two locations in pyorbital that use it. Everything should be backwards compatible except:

  • __str__ now uses the new name
  • to_dict now uses the new name
  • Closes #xxxx
  • Tests added
  • Fully documented

@djhoese djhoese requested review from adybbroe, mraspaud and pnuu October 17, 2025 01:39
@djhoese djhoese self-assigned this Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (860e0aa) to head (45cb9d1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pyorbital/orbital.py 80.00% 3 Missing ⚠️
pyorbital/tlefile.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   90.46%   90.35%   -0.11%     
==========================================
  Files          19       19              
  Lines        3019     3027       +8     
==========================================
+ Hits         2731     2735       +4     
- Misses        288      292       +4     
Flag Coverage Δ
unittests 90.35% <86.48%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Coverage Status

coverage: 90.315% (-0.1%) from 90.421%
when pulling 45cb9d1 on djhoese:feat-eccentricity
into f1c2797 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 0d11a75 into pytroll:main Oct 17, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants