Update VIIRS L1b reader to use additional netcdf attributes #2891
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 383 383
Lines 55688 55691 +3
=======================================
+ Hits 53534 53537 +3
Misses 2154 2154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 13574300409Details
💛 - Coveralls |
There was a problem hiding this comment.
While I'm fine with this as a short term solution, I think this is yet another case of the readers maybe being too restrictive/inflexible for what some users really want. Or rather, it forces us to draw the line on what satpy readers really are. Are they generic readers that provide all the information from the files in a semi-standard way? Or do they provide only the information that is shared between all (most) Satpy readers (the data + common metadata)?
Side question: Should the orbit information go in an orbital_parameters sub-dictionary like we do for lon/lat/alt information: https://satpy.readthedocs.io/en/stable/reading.html#orbital-parameters
satpy/readers/viirs_l1b.py
Outdated
| @property | ||
| def day_night_flag(self): | ||
| """Get the day/night flag.""" | ||
| return self["/attr/DayNightFlag"] | ||
|
|
||
| @property | ||
| def start_direction(self): | ||
| """Get the swath start direction flag.""" | ||
| return self["/attr/startDirection"] | ||
|
|
||
| @property | ||
| def end_direction(self): | ||
| """Get the swath end direction flag.""" | ||
| return self["/attr/endDirection"] | ||
|
|
There was a problem hiding this comment.
I don't see a reason for these to be properties on the class. Could you change this to just access self["/attr/endDirection"] (and the others) directly in the get_metadata method?
satpy/readers/viirs_l1b.py
Outdated
| "day_night": self.day_night_flag, | ||
| "start_direction": self.start_direction, | ||
| "end_direction": self.end_direction, |
There was a problem hiding this comment.
Could/should one or more of these go into an orbital_parameters sub-dictionary?
https://satpy.readthedocs.io/en/stable/reading.html#dataset-metadata
If you ask me, I think we should provide everything that is in the file
I think it’s fine like it in now. |
|
@djhoese ok to merge this? |
djhoese
added
enhancement
There was a problem hiding this comment.
As discussed in slack, could you please move start/end_direction to a new orbital_parameters sub-dictionary. Also copy start/end_orbit to that dictionary too so it'll be in both places for backwards compatibility. I think these 4 keys should be added to the orbital parameters documentation here: https://satpy.readthedocs.io/en/stable/reading.html#orbital-parameters
The VIIRS L1b reader (NASA format VIIRS data) misses some netCDF attributes that may be useful to users.
This PR adds those attributes: The day/night flag (
Day,NightorBoth) and the starting plus ending orbital direction (AscendingorDescending). I also added a test to make sure the attrs are being read.