-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fill value removal for non-integer FCI data #3060
base: main
Are you sure you want to change the base?
Fix fill value removal for non-integer FCI data #3060
Conversation
Drop _FillValue attribute when we don't have counts. We were dropping the FillValue attribute instead, which I think does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix! I wouldn't be surprised if FillValue
was used in an old test file format version available when that part of code was written, and it got fixed in the meanwhile.
There are two more occurrences of |
Yes, I also noticed. Those could also be fixed to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 383 383
Lines 55685 55694 +9
=======================================
+ Hits 53523 53532 +9
Misses 2162 2162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix removing the
_FillValue
attribute for non-integer FCI data. Satpy was removing the non-existingFillValue
attribute instead. Retaining the_FillValue
was causing problems as described in #3058.