Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent call to obj.__dict__ when obj is a compound variable. #3069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mataeui
Copy link

@mataeui mataeui commented Feb 20, 2025

@djhoese djhoese changed the title #3066 Prevent call to obj.__dict__ when obj is a compound variable. Prevent call to obj.__dict__ when obj is a compound variable. Feb 20, 2025
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this fix. I have a few comments below.

@mataeui mataeui force-pushed the main branch 3 times, most recently from 7b7d8f1 to 2953e33 Compare February 20, 2025 18:36
@mataeui
Copy link
Author

mataeui commented Feb 21, 2025

I assume that:

docs/readthedocs.org:satpy — Read the Docs build failed!

Is nothing to do with me.

@djhoese
Copy link
Member

djhoese commented Feb 21, 2025

Correct. It's a bug/memory leak in the new version of sphinx that I'm working on fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetCDF4FileHandler faults when using obj.__dict__ called when object is a compound variable.
2 participants