Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs + made mpl swatch look more similar to bokeh swatch #2

Merged
merged 15 commits into from
Nov 22, 2019

Conversation

story645
Copy link
Collaborator

@story645 story645 commented Nov 7, 2019

Bit of all the things:

  1. moved around doc & removed references to colorcet
  2. added hook to customize mpl swatch to look closer to bokeh swatch
  3. edited contribute doc
  4. added PR template

@jsignell
Copy link
Member

I'm rebasing this PR now and removing output from notebooks.

@story645
Copy link
Collaborator Author

Ack, sorry! #3 was such a mess that I forgot about this one. I can also rebase if you want.

@jsignell
Copy link
Member

@story645 what do you think is the best way to ensure that people clear the output from the notebook before checking it in? A pre-commit hook?

@story645
Copy link
Collaborator Author

Probably, and also maybe adding it to the PR instructions and templates? I totally forgot that docs build systems run notebooks.

@jsignell
Copy link
Member

I made the colormaps a gallery and condensed the two top level notebooks into one. Should make it easier to figure out.

@jsignell
Copy link
Member

Deployed at https://pyviz-dev.github.io/contrib_colormaps/index.html
Will merge when green.

@jsignell jsignell merged commit ed4c4fc into master Nov 22, 2019
@jsignell jsignell deleted the docs branch November 22, 2019 16:49
@ceball
Copy link

ceball commented Nov 22, 2019

@jsignell I just happened to notice that there are In and Out prompts:

Screenshot from 2019-11-22 19-09-22

Is that via some setting (i.e. deliberate), or has something changed...?

@jsignell
Copy link
Member

This site is using a different theme (alabaster) than the holoviz ones (sphinx_holovix_theme). I had assumed that the prompt numbers on our holoviz sites were being hidden by the theme, rather than by nbsite.

@ceball
Copy link

ceball commented Nov 22, 2019

Ah right, that makes sense, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants