Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two edits to the uvpointcloud sop that i believe are bug fixes --
Before and after of the grid change below, pictured with 128x128, with a tiling texture showing one square per pixel. Note that in the before, points start in one corner at 0.0, 0.0 in uv space, and gradually drift as they approach the center. In the after, points are always at the center of each pixel.
I didn't capture a screenshot of the divide change, but the issue it fixes is clearly visible in the screenshots around the center left (5, f, g, 6, 7, g) where that quad's points all were offset slightly behind the mesh.
before
after
(ps: qlib is super useful to me, thanks a ton for creating and maintaining it)