Update experiment API #1065
Update experiment API #1065
Conversation
There was a problem hiding this comment.
Heya @KochTobi, I tested it out and it works, nicely done! However i have a question and minor request for updated JD which would be nice if they were addressed
...anagement/src/main/java/life/qbic/projectmanagement/application/api/AsyncProjectService.java
Show resolved
Hide resolved
| sealed interface ExperimentUpdateRequestBody permits ConfoundingVariableAdditions, | ||
| ConfoundingVariableDeletions, ConfoundingVariableUpdates, ExperimentDescription, | ||
| ExperimentalGroups, ExperimentalVariableAdditions, ExperimentalVariableDeletions { | ||
|
|
||
| } |
There was a problem hiding this comment.
Since i'm not up to date i assume that i missed something so here's my question:
What's the advantage of having an interface that could be any of these possibilities?
As i saw below, this leads to the burden of the service implementation to account for all cases individually.
Could this be seperated into individual use cases to avoid an extending switch statement?
There was a problem hiding this comment.
The advantage is that we do not have a lot of interface methods while the switch enforces us to implement each possible input that can be there. Given that the switch statement does not have any default path it is clear what is done where and we do not need to copy shared code (like the request id and so on) to all the single methods. Modifying a retry strategy also can be handled centrally if desired.
There was a problem hiding this comment.
It could be separated into different methods which would make it easier to specify what should be done with the input. Deciding based on what was sent works too.
Co-authored-by: steffengreiner <[email protected]>
|
Hi Steffen, the changes I introduced you cannot really test out. This PR only adds the interface methods for changing the experimental variables, experimental groups and the confounding variables of experiments. It does not offer any implementation. |
No description provided.