-
Notifications
You must be signed in to change notification settings - Fork 1
Release PR #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KochTobi
wants to merge
13
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release PR #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the maven pgp verify plugin and activates it for every module that has a src/main directory. Builds will now fail, if the signature does not validate and there is no rule specified for it in the pgp-keys.override.list. To skip manual curation of known maven artifacts, we use a pgp-keys-map from org.simplify4u.
Enables user to filter for a subset of raw datasets to prepare the download URL list. Introduces database view SQL statements for aggregated information to address this user story: information about the raw dataset and the referenced samples. Introduces a scheduled synchronization for fetching raw dataset from a remote source (e.g., openBIS) and creates a local cache table with information to improve query performance.
Use a more FOSS preserving license.
Will no generate a full software bill of materials for each module. License texts are included as well.
Removes some smelling code that can produce race conditions for the UI update. Also passes now the current UI instance as reference for background jobs with reactor. Ui getters are not thread-safe and are not guaranteed to return the intended UI reference. According to Vaadin's documentation, it is better to fetch the UI reference in the main thread and pass it to background threads explicitly. Also, this PR enforces the server to push changes to the UI, since with automatic polling we see that the UI is not always updated despite this should be the expected behaviour when the user session lock is released. This resulted in ui components not being updated from background tasks (validation, registration pending task toast, etc) and the update was waiting for a ui interaction from the user.
* Preserve order of levels * make it compile again * wip * wip * section off regions and add borders * Replace ontology-term CSS class * Remove CSS classes Replace `.vertical-list` by `.flex-vertical .width-full` Replace `.trailing-margin-large` by `.margin-bottom-07` Replace `.trailing-margin-normal` by `.margin-bottom-05` Replace `.trailing-margin-small` by `.margin-bottom-03` * wip * add missing variables * replace lumo with custom variables * move ButtonFactory * add icon button factory method * update demo * Fix label css * replace with classes * introduce delete event * wip * add restoration option for deleted variables * Add Nullable annotation to DialogBody.java#with method * remove test button * Fix value handling of level field * Add paste behaviour * address code smells * hide public constructor * simplify memento interface removes Speculative Generality * Handle validation * Make InputValidation combinable * require all snapshots to be serializable * adapt validation to validate multivariable constraints adds validation for duplicate variable names. * wip * Add DragDropList.java * Push UI code * extract classes and add add dialog * Load values and call the service missing check for deleted variables and changes to levels. Adding, deleting, renaming and changing the unit of a variable are functional now. * remove unused method * Add empty input if no variables exist * Add variable deletion confirm dialog * add bold css class * add tooltip to locked levels Co-authored-by: Shraddha Pawar <[email protected]> * extract change records * add scroll css classes * make drag-drop configurable * replace lumo var with own variable definition Replaces the lumo variable with a custom variable. The custom variable has the same value as the lumo variable without depending on lumo and makes editing css in editors easier (as the variable is defined in the project scope and not only after compilation) * remove duplicate css classes * use correct css class * Fix import * propagate level changes address code smells * Cleanup methods * Fix inverted boolean * respect enabled state when adding and removing items * use correct variable name in changes * Prevent unintended modification on card collection Remove domain ExperimentalGroup from UI component * reload experimental variables upon completion * address code smells * enhance dragdrop hides the dragged element during dragging * reload information on attach event * remove unused code * return experimental variables sorted by variable name * Correct icon colors * update indexes * change dialog size back to medium * remove unused css * fix border colors borders in dialogs have a specific color. borders can be specifically set to not have any color. Co-authored-by: Shraddha Pawar <[email protected]> * Trim variable name input * Fix padding for linked orcid account * Change message for duplicate variable names Co-authored-by: Shraddha Pawar <[email protected]> * address wrong padding Co-authored-by: Shraddha Pawar <[email protected]> * Remove specific border color for choice box Co-authored-by: Shraddha Pawar <[email protected]> * Clarify error colors * Add dialog with dangerous confirm action * Ask directly instead of restore option Instead of presenting the user with the list of deleted experimental variables in the end, directly ask them when they delete the variable. Removes the need for the restore option as they only get removed when users confirm the intended action. * Improve check for defined variables Ignores leading and tailing whitespace when comparing variable name to existing variable names. * Do not silently remove dupliate levels in experimental variable Co-authored-by: Sven F. <[email protected]> * address review Co-authored-by: Sven F. <[email protected]> * address review * Fix sorting of variables * Remove duplicate error when level value changes Co-authored-by: Shraddha Pawar <[email protected]> * Remove error message for duplicate variable name When editing a duplicated variable name, the error message is removed. * replace choice-box css * Change error text Co-authored-by: Shraddha Pawar <[email protected]> * update dev.bundle * Fix css color * Change delete confirm text Co-authored-by: Shraddha Pawar <[email protected]> * Link javadoc Co-authored-by: Sven F. <[email protected]> * Add clarifying javadoc Co-authored-by: Sven F. <[email protected]> * remove all the generics from javadoc Co-authored-by: Sven F. <[email protected]> * address review * add missed change * address exception Co-authored-by: Sven F. <[email protected]> * Use deep copy instead of inplace modification Co-authored-by: Sven F. <[email protected]> * Remove comment I removed the comment and we will encounter the issue again if and when we try to implement a drag handle. Tracking it with our own github issue is not necessary as maybe another solution is found at a future time. * Provide exception supplier * Use UIHandle --------- Co-authored-by: KochTobi <[email protected]> Co-authored-by: Shraddha Pawar <[email protected]> Co-authored-by: Sven F. <[email protected]> Co-authored-by: Sven F. <[email protected]> Co-authored-by: Sven Fillinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
New Features 🚀
Bugfixes 🪲
Documentation & CI 🪂
Others 🧃
Full Changelog: 1.11.0...1.11.2