remove the provenance file from the dataset #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the provenance files, moves the folder into the dataset and writes the file again if something went wrong.
sven1103
previously approved these changes
Jun 3, 2024
| try { | ||
| transactionV2.moveFile(transactionV2.getIncoming().getAbsolutePath(), dataSet); | ||
| } catch (Exception e) { | ||
| Files.write(provenanceFile.toPath().toAbsolutePath(), buffer); |
There was a problem hiding this comment.
I'm like 99% sure openBIS will automatically recover deleted files (I think it stores a copy of the original folder) on failure, so I advise against writing anything after an exception the ETL service - I'm not sure how this will influence the behaviour
wow-such-code
requested changes
Jun 3, 2024
|
@wow-such-code so the recovery is not needed? |
Co-authored-by: wow-such-code <[email protected]>
Yes, it will recover by itself in an error case. The only case where files can vanish is if the script runs through without any errors and without moving files. |
wow-such-code
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the provenance files, moves the folder into the dataset and writes the file again if something went wrong.
See #3 for details on the reason for this change.