Skip to content

Comments

🎨🔨 Re-adjust the height of TimePicker on Calendar resize due to number of days#49

Merged
balajis-qb merged 3 commits intomainfrom
issue-5466/fix/update-time-select-height-on-calendar-resize
Apr 19, 2025
Merged

🎨🔨 Re-adjust the height of TimePicker on Calendar resize due to number of days#49
balajis-qb merged 3 commits intomainfrom
issue-5466/fix/update-time-select-height-on-calendar-resize

Conversation

@balajis-qb
Copy link
Collaborator

@balajis-qb balajis-qb commented Apr 7, 2025

Closes Hacker0x01#5466

Description

As mentioned in the ticket, the Time Picker height is not getting updated when we switch between months, so sometimes when we switch from 30 days month to 31 days month and vice a versa, we have some UI-issues. I added a Resize-Observer and update the time picker height whenever calendar popup height changes and updated the test cases for it.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@balajis-qb balajis-qb merged commit 6f3fe1f into main Apr 19, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time list height doesn't adjust when switching between months with different week counts

1 participant