fix: fetch http(s) type: file vector sources, reject other schemes#149
Draft
tellet-q wants to merge 1 commit into
Draft
fix: fetch http(s) type: file vector sources, reject other schemes#149tellet-q wants to merge 1 commit into
type: file vector sources, reject other schemes#149tellet-q wants to merge 1 commit into
Conversation
Validation accepted `s3://` and `http(s)://` paths, but `FBinReader::new` only opened local paths and unwrapped, so a URL panicked at upload time. Now http(s) paths download through the dataset downloader (cached under `$BFB_DATASETS_DIR/files/`), other schemes are rejected up front, and `FBinReader::new` returns `Result`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow https:// url only, reject s3://.
All Submissions:
devbranch. Did you create your branch fromdev?