fix: fix batch embedding precision and shape

[joein]

fixed precision in batch embedding tests and remove redundant dim in image expected result

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the testing logic for multimodal interactions. The nested array in CANONICAL_IMAGE_VALUES has been flattened by removing an extra outer layer. Additionally, both the test_batch_embedding and test_single_embedding functions have been modified. In these tests, the unpacking of the expected result has been simplified by removing the batch_size variable, and the tolerance in the np.allclose assertions has been increased from 1e-3 to 2e-3. There are no modifications to the declarations of exported or public entities.

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5bd5c0a and 7443327.

📒 Files selected for processing (1)

• tests/test_late_interaction_multimodal.py (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: Python 3.13.x on windows-latest test
• GitHub Check: Python 3.13.x on macos-latest test
• GitHub Check: Python 3.13.x on ubuntu-latest test
• GitHub Check: Python 3.12.x on windows-latest test
• GitHub Check: Python 3.12.x on macos-latest test
• GitHub Check: Python 3.12.x on ubuntu-latest test
• GitHub Check: Python 3.11.x on windows-latest test
• GitHub Check: Python 3.11.x on macos-latest test
• GitHub Check: Python 3.11.x on ubuntu-latest test
• GitHub Check: Python 3.10.x on windows-latest test
• GitHub Check: Python 3.10.x on macos-latest test
• GitHub Check: Python 3.10.x on ubuntu-latest test
• GitHub Check: Python 3.9.x on windows-latest test
• GitHub Check: Python 3.9.x on macos-latest test
• GitHub Check: Python 3.9.x on ubuntu-latest test
• GitHub Check: Python 3.13 test

🔇 Additional comments (3)

tests/test_late_interaction_multimodal.py (3)

14-20: Improved array structure in CANONICAL_IMAGE_VALUES

Good job flattening the array structure by removing the redundant dimension. This simplification makes the test data more readable and better matches the actual shape returned by the embedding model.

---

57-58: Appropriate shape handling and precision adjustment

The removal of batch_size from the shape unpacking and the increase in tolerance from 1e-3 to 2e-3 are good improvements:

1. The shape unpacking now correctly matches the flattened array structure
2. The increased tolerance (2e-3) allows for minor precision differences that can occur with embedding models

This change should make the tests more robust while still ensuring embedding quality.

---

68-69: Consistent shape handling in single embedding test

Good consistency by also updating the shape unpacking in the single embedding test to match the changes made to the batch embedding test. This ensures that both tests work with the same expectations regarding the embedding shape and precision.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.