Fix truncated error toast messages and expand image URL detection (#283, #253)#381
Open
srimon12 wants to merge 3 commits into
Open
Fix truncated error toast messages and expand image URL detection (#283, #253)#381srimon12 wants to merge 3 commits into
srimon12 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #283
Fixes #253
Two bug fixes for the Web UI:
1. Truncated error messages (#283)
ErrorNotifierto prevent long API error messages from overflowing the toast notificationgetErrorMessage()fallback: when the extracted message is empty or whitespace-only, it now falls back to the generic fallback message instead of showing an empty toast2. Image URL detection (#253)
image.png?w=200,photo.jpeg#fragment)bmp,ico,tiff,tif,avif,heic,heifdata:image/...URIsFiles Changed
src/components/ToastNotifications/ErrorNotifier.jsx— +14/-3src/lib/get-error-message.js— +6/-1src/components/Points/PointImage.jsx— +7/-1Verification