Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3D] Point cloud editing paintbrush tool #60386

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Withalion
Copy link
Contributor

Description

This PR adds new tool for editing point clouds. The new tool supports free movement, size change, highlighting of already selected area. Users can change the size of selection area by scrolling and the tool starts selecting on left click + drag. Cursor also shows loading while the point cloud is edited.

Screencast_20250131_193039.mp4

Funded by: Klimadatastyrelsen

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 31, 2025
@Withalion
Copy link
Contributor Author

This PR builds on work done in #60378

Copy link

github-actions bot commented Jan 31, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 2390c81)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 2390c81)

@nyalldawson nyalldawson added the Frozen Feature freeze - Do not merge! label Jan 31, 2025
@saberraz
Copy link
Contributor

saberraz commented Feb 3, 2025

I have tried this tool. Very nice addition. Some usability issues:

  • Changing paintbrush size is controlled by the middle mouse key (wheel), by rolling back and forth. This is always dedicated for map zooming in/out and it is confusing. It is best if you combine it with a hot-key.
  • More the above point, it would be good to have a dedicated pixel size for the radius of the paintbrush.
  • While using the tool, I pressed the Escape key and it crashed QGIS.

@Withalion
Copy link
Contributor Author

Paintbrush tool now supports cancellation of selection while still dragging by pressing ESC and the size of paintbrush changes by CTRL + mouse wheel.

@Withalion Withalion force-pushed the point-cloud-paintbrush branch from e04fc42 to 2390c81 Compare February 18, 2025 11:56
@nyalldawson nyalldawson removed the Frozen Feature freeze - Do not merge! label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants