Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix msvc build after untwine update #60677

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

jef-n
Copy link
Member

@jef-n jef-n commented Feb 20, 2025

No description provided.

@github-actions github-actions bot added this to the 3.42.0 milestone Feb 20, 2025
jef-n added a commit to jef-n/OSGeo4W that referenced this pull request Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c1129ed)

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit c1129ed)

@jef-n jef-n requested review from uclaros and alexbruy February 20, 2025 07:38
@uclaros
Copy link
Contributor

uclaros commented Feb 20, 2025

I'm not familiar with windows builds, I thought UNICODE was defined by default as in vcpkg builds

Copy link
Contributor

@alexbruy alexbruy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I haven't compiled QGIS on WIndows for a long time.

@jef-n jef-n merged commit 055e0c9 into qgis:master Feb 20, 2025
35 checks passed
@jef-n jef-n deleted the untwine-msvc-fix branch February 20, 2025 08:32
@ptitjano
Copy link
Collaborator

@jef-n Silly / Noob question, I don't know how the windows compilation works. why are these errors not detected by the CI?

@jef-n
Copy link
Member Author

jef-n commented Feb 20, 2025

@jef-n Silly / Noob question, I don't know how the windows compilation works. why are these errors not detected by the CI?

#57445 was not merged

jef-n added a commit to jef-n/OSGeo4W that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants