IMP: Expose new match_ids parameter #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR would need to involve editing the R scripts located in |
|
@ebolyen yeah I figured as much, I don't really know how that works, but I can figure it out |
|
@ebolyen is this the correct modifications of the R script? Seems like all I needed to do was put the arg in a variable then pass it off. |
thermokarst
reviewed
Sep 12, 2019
|
Hey there @ChrisKeefe, can you please review this PR when you get a chance? Please address any changes you might want made to @ebolyen & I - we are teaming up to run this one across the finish line! |
|
This is probably best addressed by qiime2/q2-types#207, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #118. This currently adds no new unit tests because honestly I'm not 100% on what this behavior is meant to do (it seems to have something to do with mixed orientation), but it does expose the new parameter. Additionally, I'm not positive that it's actually being sent to R properly (in fact I have a strong suspicion it isn't) because I've never tried to do this before, but it's a start.