Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMP: 'subsample' action renamed to 'subsample_ids' #301

Merged
merged 9 commits into from
Jan 4, 2024

Conversation

hagenjp
Copy link
Contributor

@hagenjp hagenjp commented Dec 22, 2023

Closes: #299

@hagenjp hagenjp requested a review from lizgehret December 22, 2023 22:14
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenjp! This mostly looks good, but the tests are failing because you've replaced the name of an external method (Table.subsample) with subsample_ids, which doesn't exist. I'm going to let you find the instances of this and replace them with the original method, because I think it's a good exercise to recognize the difference between external methods that we're calling and our own internal methods (within QIIME 2). In your basecamp message, you already identified where that external method is being called from, so I'll let you extrapolate from there 🙂

Let me know if you have any questions!

@hagenjp hagenjp requested a review from lizgehret January 3, 2024 17:12
@hagenjp
Copy link
Contributor Author

hagenjp commented Jan 3, 2024

@lizgehret this pr is ready for round two review from you :)

Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one small comment inline!

@lizgehret
Copy link
Member

looks great, thanks @hagenjp!

@lizgehret lizgehret merged commit 9f87ffb into qiime2:dev Jan 4, 2024
4 checks passed
@lizgehret lizgehret changed the title IMP: Subsample action renamed to 'subsample_ids' IMP: 'subsample' action renamed to 'subsample_ids' Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

rename subsample action to subsample-ids
2 participants