-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMP: 'subsample' action renamed to 'subsample_ids' #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenjp! This mostly looks good, but the tests are failing because you've replaced the name of an external method (Table.subsample
) with subsample_ids
, which doesn't exist. I'm going to let you find the instances of this and replace them with the original method, because I think it's a good exercise to recognize the difference between external methods that we're calling and our own internal methods (within QIIME 2). In your basecamp message, you already identified where that external method is being called from, so I'll let you extrapolate from there 🙂
Let me know if you have any questions!
@lizgehret this pr is ready for round two review from you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one small comment inline!
Co-authored-by: Liz Gehret <[email protected]>
looks great, thanks @hagenjp! |
Closes: #299