tweak comments and tests

- fix an error comment - uncomment some test params for more test cases - ignore ENOENT error when cleanup files after testing
qiniu · Mar 12, 2024 · f9645c8 · f9645c8
1 parent 8b0d320
commit f9645c8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/qiniu/httpc/client.js b/qiniu/httpc/client.js
@@ -82,7 +82,8 @@ HttpClient.prototype.sendRequest = function (requestOptions) {
     const resPromise = handle(requestOptions);
 
     if (requestOptions.callback) {
-        // callback error will be chained to result.
+        // user should handle callback error outside.
+        // already wrapped callback for inner usage in storage.
         resPromise.then(({ data, resp }) => {
             requestOptions.callback(null, data, resp);
         });

diff --git a/test/form_up.test.js b/test/form_up.test.js
@@ -33,7 +33,7 @@ after(function () {
             testFilePath2
         ].map(p => new Promise(resolve => {
             fs.unlink(p, err => {
-                if (err) {
+                if (err && err.code !== 'ENOENT') {
                     console.log(`unlink ${p} failed`, err);
                 }
                 resolve();

diff --git a/test/resume_up.test.js b/test/resume_up.test.js
@@ -72,7 +72,7 @@ after(function () {
             testFilePath
         ].map(p => new Promise(resolve => {
             fs.unlink(p, err => {
-                if (err) {
+                if (err && err.code !== 'ENOENT') {
                     console.log(`unlink ${p} failed`, err);
                 }
                 resolve();
@@ -384,22 +384,21 @@ describe('test resume up', function () {
             {
                 name: 'version',
                 values: [
-                    // undefined,
+                    undefined,
                     'v1',
                     'v2'
                 ]
             },
-            // {
-            //     name: 'partSize',
-            //     values: [
-            //         undefined,
-            //         6 * 1024 * 1024
-            //     ]
-            // },
+            {
+                name: 'partSize',
+                values: [
+                    undefined,
+                    6 * 1024 * 1024
+                ]
+            },
             {
                 name: 'fileSizeMB',
-                // values: [2, 4, 6, 10]
-                values: [2, 10]
+                values: [2, 4, 6, 10]
             }
         );
 
@@ -408,7 +407,7 @@ describe('test resume up', function () {
             return Promise.all(
                 filepathListToDelete.map(p => new Promise(resolve => {
                     fs.unlink(p, err => {
-                        if (err) {
+                        if (err && err.code !== 'ENOENT') {
                             console.log(`unlink ${p} failed`, err);
                         }
                         resolve();