Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkcov in CI #111

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Add Checkcov in CI #111

merged 7 commits into from
Jan 24, 2024

Conversation

vmercierfr
Copy link
Collaborator

Objective

Add checkcov in CI

Why

Checkcov will help us to detect misconfigurations before they're deployed.

How

  • Add checkcov in CI
  • Add checkcov command in the makefile
  • Fix missing Docker HEALTHCHECK
  • Fix container running in root by using restricted sudo
  • Ignore CKV_AWS_356 because it raise false positive alerts

Release plan

  • Merge this PR
  • Apply with CI

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@vmercierfr vmercierfr linked an issue Jan 23, 2024 that may be closed by this pull request
@vmercierfr vmercierfr requested review from qfritz and dcupif January 23, 2024 21:05
@vmercierfr
Copy link
Collaborator Author

#sre

Signed-off-by: Vincent Mercier <[email protected]>
Signed-off-by: Vincent Mercier <[email protected]>
Signed-off-by: Vincent Mercier <[email protected]>
This rule return false positive results for some statement like rds:DescribePendingMaintenanceActions

Signed-off-by: Vincent Mercier <[email protected]>
Copy link

Code Coverage

Package Line Rate Health
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch 88%
github.com/qonto/prometheus-rds-exporter/internal/app/ec2 88%
github.com/qonto/prometheus-rds-exporter/internal/app/exporter 80%
github.com/qonto/prometheus-rds-exporter/internal/app/rds 80%
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas 51%
github.com/qonto/prometheus-rds-exporter/internal/app/unit 100%
Summary 81% (939 / 1157)

Minimum allowed line rate is 60%

Copy link
Member

@victorboissiere victorboissiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmercierfr vmercierfr merged commit d2a70ff into main Jan 24, 2024
11 checks passed
@vmercierfr vmercierfr deleted the add-checkcov branch January 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply best practices to Docker
2 participants