-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: esp-qcom-image: convert to OE-core uki.bbclass #138
Closed
+29
−135
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0c118aa
uki-esp-image bbclass: initial add
koenkooi 729f6bb
esp-qcom-image: convert to use OE-core UKI infrastructure
koenkooi ef37c09
SQUASH ME: uki-esp-image: convert to type#2
koenkooi f6c3e55
SQUASH ME: fix UKI location
koenkooi 18c8360
SQUASH ME: uki-esp-image: s/ESP/EFI/
koenkooi c1d5827
SQUASH ME: remove systemd-boot configs
koenkooi 67818f6
SQUASH ME: esp-qcom-image: unset KERNEL_DEVICETREE
koenkooi 2c1b663
esp-qcom-image: provide custom kernel cmdline
koenkooi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Create an ESP image that has a type #2 EFI UKI and systemd-boot | ||
|
||
# Optional subfolder, dependant on where the ESP partition gets mounted | ||
# intended to only have a leading slash, no trailing slash e.g. '/EFI', or just empty, '' | ||
ESPFOLDER ?= "/EFI" | ||
|
||
do_ukiesp() { | ||
mkdir -p ${IMAGE_ROOTFS}${ESPFOLDER}/EFI/Linux | ||
|
||
# Copy over files from deploy into the rootfs | ||
install -m 0755 ${DEPLOY_DIR_IMAGE}/${UKI_FILENAME} ${IMAGE_ROOTFS}${ESPFOLDER}/EFI/Linux | ||
} | ||
|
||
addtask ukiesp after do_deploy uki before do_image_complete do_image_wic | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that in our current UKI (we build with linux-qcom-uki) we do not set an initrd, while I think there is one by default with the upstream uki class. It's a boot behavior change that we need to be aware of. We might want an initrd, but we should not make this change without an explicit commit/discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initrd or initramfs? They are subtly different in how the / mountpoint is pivoted or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use none of them right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to use initrd with meta-qcom-distro, but here I don't think it is needed / used.